Horton

Stop including {brin,gin}_tuple.h in tuplesort.h

Álvaro Herrera <alvherre@kurilemu.de>

View on postgr.es
Commit: 225d1df1d299061498182714d207fae77436702c
Author: Álvaro Herrera <alvherre@kurilemu.de>
Date: 2026-01-12T17:09:49Z
Releases: 19 (unreleased) 
Stop including {brin,gin}_tuple.h in tuplesort.h

Doing this meant that those two headers, which are supposed to be
internal to their corresponding index AMs, were being included pretty
much universally, because tuplesort.h is included by execnodes.h which
is very widely used.  Stop that, and fix fallout.

We also change indexing.h to no longer include execnodes.h (tuptable.h
is sufficient), and relscan.h to no longer include buf.h (pointless
since c2fe139c201c).

Author: Mario González <gonzalemario@gmail.com>
Discussion: https://postgr.es/m/CAFsReFUcBFup=Ohv_xd7SNQ=e73TXi8YNEkTsFEE2BW7jS1noQ@mail.gmail.com

Files

PathChange+/−
contrib/pageinspect/gistfuncs.c modified +1 −0
src/backend/access/gin/gininsert.c modified +2 −1
src/backend/catalog/pg_attrdef.c modified +1 −0
src/backend/catalog/pg_largeobject.c modified +1 −0
src/backend/commands/collationcmds.c modified +1 −0
src/backend/commands/user.c modified +1 −0
src/backend/executor/execReplication.c modified +1 −0
src/backend/parser/parse_expr.c modified +1 −0
src/backend/replication/logical/relation.c modified +1 −0
src/backend/replication/logical/sequencesync.c modified +1 −0
src/backend/statistics/stat_utils.c modified +1 −0
src/include/access/relscan.h modified +0 −1
src/include/catalog/indexing.h modified +1 −1
src/include/nodes/execnodes.h modified +2 −0
src/include/utils/tuplesort.h modified +3 −2

Discussion