Centralize libpq's low-level code for dropping a connection.
Tom Lane <tgl@sss.pgh.pa.us>
Centralize libpq's low-level code for dropping a connection. Create an internal function pqDropConnection that does the physical socket close and cleans up closely-associated state. This removes a bunch of ad hoc, not always consistent closure code. The ulterior motive is to have a single place to wait for a spawned child backend to exit, but this seems like good cleanup even if that never happens. I went back and forth on whether to include "conn->status = CONNECTION_BAD" in pqDropConnection's actions, but for the moment decided not to. Only a minority of the call sites actually want that, and in any case it's arguable that conn->status is slightly higher-level state, and thus not part of this function's purview.
Files
| Path | Change | +/− |
|---|---|---|
| src/interfaces/libpq/fe-connect.c | modified | +35 −60 |
| src/interfaces/libpq/fe-misc.c | modified | +1 −4 |
| src/interfaces/libpq/fe-protocol3.c | modified | +1 −3 |
| src/interfaces/libpq/libpq-int.h | modified | +1 −0 |