Fix new pg_publication_tables query.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 20b6847176976da9cae6103475b967e6c2971898
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2022-09-06T22:00:32Z
Releases: 16.0
Fix new pg_publication_tables query.

The addition of published column names forgot to filter on attisdropped,
leading to cases where you could see "........pg.dropped.1........"
or the like as a reportedly-published column.

While we're here, rewrite the new subquery to get a more efficient plan
for it.

Hou Zhijie, per report from Jaime Casanova.  Back-patch to v15 where
the bug was introduced.  (Sadly, this means we need a post-beta4
catversion bump before beta4 has even hit the streets.  I see no
good alternative though.)

Discussion: https://postgr.es/m/Yxa1SU4nH2HfN3/i@ahch-to

Files

Discussion