Improve parser so that we can show an error cursor position for errors

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 20ab467d76d78271006818d2baf4c9c8658d1f38
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2006-03-14T22:48:25Z
Releases: 8.2.0
Improve parser so that we can show an error cursor position for errors
during parse analysis, not only errors detected in the flex/bison stages.
This is per my earlier proposal.  This commit includes all the basic
infrastructure, but locations are only tracked and reported for errors
involving column references, function calls, and operators.  More could
be done later but this seems like a good set to start with.  I've also
moved the ReportSyntaxErrorPosition logic out of psql and into libpq,
which should make it available to more people --- even within psql this
is an improvement because warnings weren't handled by ReportSyntaxErrorPosition.

Files

PathChange+/−
contrib/earthdistance/expected/earthdistance.out modified +12 −4
src/backend/access/common/tupdesc.c modified +2 −2
src/backend/catalog/pg_aggregate.c modified +3 −3
src/backend/catalog/pg_operator.c modified +4 −3
src/backend/commands/aggregatecmds.c modified +6 −6
src/backend/commands/comment.c modified +11 −21
src/backend/commands/define.c modified +4 −9
src/backend/commands/functioncmds.c modified +8 −42
src/backend/commands/opclasscmds.c modified +9 −9
src/backend/commands/operatorcmds.c modified +9 −7
src/backend/commands/schemacmds.c modified +2 −2
src/backend/commands/sequence.c modified +12 −19
src/backend/commands/tablecmds.c modified +13 −20
src/backend/commands/typecmds.c modified +45 −106
src/backend/commands/view.c modified +3 −7
src/backend/executor/spi.c modified +2 −2
src/backend/nodes/copyfuncs.c modified +5 −1
src/backend/nodes/equalfuncs.c modified +5 −1
src/backend/nodes/makefuncs.c modified +41 −3
src/backend/nodes/outfuncs.c modified +5 −1
src/backend/nodes/readfuncs.c modified +3 −1
src/backend/optimizer/plan/initsplan.c modified +4 −3
src/backend/optimizer/util/clauses.c modified +2 −2
src/backend/parser/analyze.c modified +16 −10
src/backend/parser/gram.y modified +138 −83
src/backend/parser/parse_clause.c modified +9 −5
src/backend/parser/parse_expr.c modified +104 −58
src/backend/parser/parse_func.c modified +38 −24
src/backend/parser/parse_node.c modified +36 −1
src/backend/parser/parse_oper.c modified +60 −51
src/backend/parser/parse_relation.c modified +28 −18
src/backend/parser/parse_target.c modified +7 −5
src/backend/parser/parse_type.c modified +24 −14
src/backend/parser/scan.l modified +67 −36
src/backend/tcop/postgres.c modified +9 −4
src/backend/utils/adt/ruleutils.c modified +8 −5
src/bin/psql/common.c modified +1 −231
src/include/nodes/makefuncs.h modified +5 −3
src/include/nodes/parsenodes.h modified +13 −4
src/include/parser/analyze.h modified +5 −4
src/include/parser/gramparse.h modified +10 −1
src/include/parser/parse_func.h modified +3 −2
src/include/parser/parse_node.h modified +13 −1
src/include/parser/parse_oper.h modified +18 −11
src/include/parser/parse_relation.h modified +8 −5
src/include/parser/parse_type.h modified +4 −4
src/include/tcop/tcopprot.h modified +2 −2
src/interfaces/libpq/fe-connect.c modified +3 −1
src/interfaces/libpq/fe-exec.c modified +22 −1
src/interfaces/libpq/fe-protocol3.c modified +240 −7
src/interfaces/libpq/libpq-int.h modified +2 −1
src/pl/plperl/expected/plperl_elog.out modified +2 −0
src/pl/plperl/plperl.c modified +12 −27
src/pl/plpgsql/src/pl_comp.c modified +2 −2
src/pl/plpython/plpython.c modified +9 −3
src/pl/tcl/pltcl.c modified +7 −23
src/test/regress/expected/alter_table.out modified +42 −0
src/test/regress/expected/arrays.out modified +4 −0
src/test/regress/expected/errors.out modified +53 −45
src/test/regress/expected/geometry_1.out modified +2 −0
src/test/regress/expected/geometry_2.out modified +2 −0
src/test/regress/expected/geometry.out modified +2 −0
src/test/regress/expected/horology.out modified +2 −0
src/test/regress/expected/join_1.out modified +2 −0
src/test/regress/expected/join.out modified +2 −0
src/test/regress/expected/plpgsql.out modified +20 −16
src/test/regress/expected/prepare.out modified +2 −0
src/test/regress/expected/rowtypes.out modified +4 −0
src/test/regress/expected/select_implicit_1.out modified +6 −0
src/test/regress/expected/select_implicit_2.out modified +6 −0
src/test/regress/expected/select_implicit.out modified +6 −0
src/test/regress/expected/strings.out modified +37 −13
src/test/regress/expected/time.out modified +2 −0
src/test/regress/expected/timetz.out modified +2 −0
src/test/regress/expected/transactions.out modified +4 −0
src/test/regress/expected/union.out modified +2 −0
src/test/regress/expected/update.out modified +2 −0
src/test/regress/expected/without_oid.out modified +6 −0
src/test/regress/output/constraints.source modified +2 −2
src/test/regress/output/create_function_1.source modified +1 −1