Add BufFileRead variants with short read and EOF detection
Peter Eisentraut <peter@eisentraut.org>
Add BufFileRead variants with short read and EOF detection Most callers of BufFileRead() want to check whether they read the full specified length. Checking this at every call site is very tedious. This patch provides additional variants BufFileReadExact() and BufFileReadMaybeEOF() that include the length checks. I considered changing BufFileRead() itself, but this function is also used in extensions, and so changing the behavior like this would create a lot of problems there. The new names are analogous to the existing LogicalTapeReadExact(). Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/f3501945-c591-8cc3-5ef0-b72a2e0eaa9c@enterprisedb.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/gist/gistbuildbuffers.c | modified | +1 −6 |
| src/backend/backup/backup_manifest.c | modified | +1 −8 |
| src/backend/executor/nodeHashjoin.c | modified | +4 −14 |
| src/backend/replication/logical/worker.c | modified | +4 −28 |
| src/backend/storage/file/buffile.c | modified | +47 −3 |
| src/backend/utils/sort/logtape.c | modified | +1 −8 |
| src/backend/utils/sort/sharedtuplestore.c | modified | +6 −43 |
| src/backend/utils/sort/tuplestore.c | modified | +6 −23 |
| src/include/storage/buffile.h | modified | +3 −1 |
Discussion
- Add BufFileRead variants with short read and EOF detection 8 messages · 2022-12-28 → 2023-01-16