Fix platform-specific performance regression in logtape.c.

Jeff Davis <jdavis@postgresql.org>

Commit: 1fbb6c93df30801f83c6804ab7befde3cdefe677
Author: Jeff Davis <jdavis@postgresql.org>
Date: 2020-06-07T16:25:55Z
Releases: 13.0
Fix platform-specific performance regression in logtape.c.

Commit 24d85952 made a change that indirectly caused a performance
regression by triggering a change in the way GCC optimizes memcpy() on
some platforms.

The behavior seemed to contradict a GCC document, so I filed a report:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95556

This patch implements a narrow workaround which eliminates the
regression I observed. The workaround is benign enough that it seems
unlikely to cause a different regression on another platform.

Discussion: https://postgr.es/m/99b2eab335c1592c925d8143979c8e9e81e1575f.camel@j-davis.com

Files

PathChange+/−
src/backend/utils/sort/logtape.c modified +1 −1

Discussion