Horton

Add missing EmitWarningsOnPlaceholders() calls.

Tom Lane <tgl@sss.pgh.pa.us>

View on postgr.es
Commit: 1fada5d81e6769ded832a4ca62ee9371bac3fb9f
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-12-21T17:12:24Z
Releases: 15.0 
Add missing EmitWarningsOnPlaceholders() calls.

Extensions that define any custom GUCs should call
EmitWarningsOnPlaceholders after doing so, to help catch misspellings.
Many of our contrib modules hadn't gotten the memo on that, though.

Also add such calls to src/test/modules extensions that have GUCs.
While these aren't really user-facing, they should illustrate good
practice not faulty practice.

Shinya Kato

Discussion: https://postgr.es/m/524fa2c0a34f34b68fbfa90d0760d515@oss.nttdata.com

Files

PathChange+/−
contrib/auth_delay/auth_delay.c modified +3 −0
contrib/pg_trgm/trgm_op.c modified +2 −0
contrib/postgres_fdw/option.c modified +2 −0
contrib/sepgsql/hooks.c modified +2 −0
src/backend/utils/misc/guc.c modified +7 −0
src/pl/tcl/pltcl.c modified +3 −0
src/test/modules/delay_execution/delay_execution.c modified +2 −0
src/test/modules/ssl_passphrase_callback/ssl_passphrase_func.c modified +3 −0
src/test/modules/worker_spi/worker_spi.c modified +2 −0

Discussion