vacuumdb: Skip temporary tables in query to build list of relations

Michael Paquier <michael@paquier.xyz>

Commit: 1ea4d9c001e686133f6f7c553221abd109117a0c
Author: Michael Paquier <michael@paquier.xyz>
Date: 2024-09-25T05:44:53Z
Releases: 16.5
vacuumdb: Skip temporary tables in query to build list of relations

Running vacuumdb with a non-superuser while another user has created a
temporary table would lead to a mid-flight permission failure,
interrupting the operation.  vacuum_rel() skips temporary relations of
other backends, and it makes no sense for vacuumdb to know about these
relations, so let's switch it to ignore temporary relations entirely.

Adding a qual in the query based on relpersistence simplifies the
generation of its WHERE clause in vacuum_one_database(), per se the
removal of "has_where".

Author: VaibhaveS, Michael Paquier
Reviewed-by: Fujii Masao
Discussion: https://postgr.es/m/CAM_eQjwfAR=y3G1fGyS1U9FTmc+FyJm9amNfY2QCZBnDDbNPZg@mail.gmail.com
Backpatch-through: 12

Files

PathChange+/−
src/bin/scripts/vacuumdb.c modified +25 −15

Discussion