Prevent corner-case core dump in rfree().

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 1de1e3d440464a54d8f6a89c59c1f5a8c3e5731b
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-07-15T17:28:27Z
Releases: 8.4.13
Prevent corner-case core dump in rfree().

rfree() failed to cope with the case that pg_regcomp() had initialized the
regex_t struct but then failed to allocate any memory for re->re_guts (ie,
the first malloc call in pg_regcomp() failed).  It would try to touch the
guts struct anyway, and thus dump core.  This is a sufficiently narrow
corner case that it's not surprising it's never been seen in the field;
but still a bug is a bug, so patch all active branches.

Noted while investigating whether we need to call pg_regfree after a
failure return from pg_regcomp.  Other than this bug, it turns out we
don't, so adjust comments appropriately.

Files

PathChange+/−
src/backend/regex/regcomp.c modified +15 −9
src/backend/utils/adt/regexp.c modified +1 −2