Fix estimate_num_groups() to not fail on PlaceHolderVars, per report from
Tom Lane <tgl@sss.pgh.pa.us>
Fix estimate_num_groups() to not fail on PlaceHolderVars, per report from Stefan Kaltenbrunner. The most reasonable behavior (at least for the near term) seems to be to ignore the PlaceHolderVar and examine its argument instead. In support of this, change the API of pull_var_clause() to allow callers to request recursion into PlaceHolderVars. Currently estimate_num_groups() is the only customer for that behavior, but where there's one there may be others.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/catalog/heap.c | modified | +3 −3 |
| src/backend/optimizer/path/allpaths.c | modified | +2 −2 |
| src/backend/optimizer/path/equivclass.c | modified | +3 −2 |
| src/backend/optimizer/plan/createplan.c | modified | +3 −2 |
| src/backend/optimizer/plan/initsplan.c | modified | +4 −3 |
| src/backend/optimizer/plan/planner.c | modified | +2 −2 |
| src/backend/optimizer/prep/preptlist.c | modified | +3 −2 |
| src/backend/optimizer/util/placeholder.c | modified | +2 −2 |
| src/backend/optimizer/util/tlist.c | modified | +3 −2 |
| src/backend/optimizer/util/var.c | modified | +24 −14 |
| src/backend/utils/adt/selfuncs.c | modified | +6 −3 |
| src/include/optimizer/var.h | modified | +8 −2 |