Horton

Code review for c94e6942cefe7d20c5feed856e27f672734b1e2b.

Robert Haas <rhaas@postgresql.org>

View on postgr.es
Commit: 1d5fede4a900d135745c1fa5a70dcfe0b3359e3d
Author: Robert Haas <rhaas@postgresql.org>
Date: 2017-04-12T15:35:11Z
Releases: 10.0 
Code review for c94e6942cefe7d20c5feed856e27f672734b1e2b.

validateCheckConstraint() shouldn't try to access the storage for
a partitioned table, because it no longer has any.  Creating a
_RETURN table on a partitioned table shouldn't be allowed, both
because there's no value in it and because trying to do so would
involve a validation scan against its nonexistent storage.

Amit Langote, reviewed by Tom Lane.  Regression test outputs
updated to pass by me.

Discussion: http://postgr.es/m/e5c3cbd3-1551-d6f8-c9e2-51777d632fd2@lab.ntt.co.jp

Files

PathChange+/−
src/backend/commands/tablecmds.c modified +6 −2
src/backend/rewrite/rewriteDefine.c modified +6 −0
src/test/regress/expected/alter_table.out modified +6 −0
src/test/regress/expected/rules.out modified +5 −0
src/test/regress/sql/alter_table.sql modified +7 −0
src/test/regress/sql/rules.sql modified +5 −0

Discussion