Fix walsender error cleanup code

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: 1d3743023ef8fa665902e791b0d52e9a1ab419cb
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2020-05-16T00:00:52Z
Releases: 13.0
Fix walsender error cleanup code

In commit 850196b610d2 I (Álvaro) failed to handle the case of walsender
shutting down on an error before setting up its 'xlogreader' pointer;
the error handling code dereferences the pointer, causing a crash.
Fix by testing the pointer before trying to dereference it.

Kyotaro authored the code fix; I adopted Nathan's test case to be used
by the TAP tests and added the necessary PostgresNode change.

Reported-by: Nathan Bossart <bossartn@amazon.com>
Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/C04FC24E-903D-4423-B312-6910E4D846E5@amazon.com

Files

Discussion