Improve JsonLexContext's freeability
Alvaro Herrera <alvherre@alvh.no-ip.org>
Improve JsonLexContext's freeability Previously, the JSON code didn't have to worry too much about freeing JsonLexContext, because it was never too long-lived. With new features being added for SQL/JSON this is no longer the case. Add a routine that knows how to free this struct and apply that to a few places, to prevent this from becoming problematic. At the same time, we change the API of makeJsonLexContextCstringLen to make it receive a pointer to JsonLexContext for callers that want it to be stack-allocated; it can also be passed as NULL to get the original behavior of a palloc'ed one. This also causes an ABI break due to the addition of flags to JsonLexContext, so we can't easily backpatch it. AFAICS that's not much of a problem; apparently some leaks might exist in JSON usage of text-search, for example via json_to_tsvector, but I haven't seen any complaints about that. Per Coverity complaint about datum_to_jsonb_internal(). Discussion: https://postgr.es/m/20230808174110.oq3iymllsv6amkih@alvherre.pgsql
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/utils/adt/jsonb.c | modified | +7 −6 |
| src/backend/utils/adt/json.c | modified | +22 −17 |
| src/backend/utils/adt/jsonfuncs.c | modified | +57 −50 |
| src/bin/pg_verifybackup/parse_manifest.c | modified | +3 −1 |
| src/common/jsonapi.c | modified | +41 −5 |
| src/include/common/jsonapi.h | modified | +21 −5 |
| src/include/utils/jsonfuncs.h | modified | +2 −2 |
Discussion
- pgsql: Some refactoring to export json(b) conversion functions 3 messages · 2023-07-26 → 2023-10-05