Allow psql to re-use connection parameters after a connection loss.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 1b62d0fb3e50ede570d0d4e4a2be69d5645b48a7
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2020-10-23T21:07:15Z
Releases: 14.0
Allow psql to re-use connection parameters after a connection loss.

Instead of immediately PQfinish'ing a dead connection, save it aside
so that we can still extract its parameters for \connect attempts.
(This works because PQconninfo doesn't care whether the PGconn is in
CONNECTION_BAD state.)  This allows developers to reconnect with
just \c after a database crash and restart.

It's tempting to use the same approach instead of closing the old
connection after a failed non-interactive \connect command.  However,
that would not be very safe: consider a script containing
	\c db1 user1 live_server
	\c db2 user2 dead_server
	\c db3
The script would be expecting to connect to db3 at dead_server, but
if we re-use parameters from the first connection then it might
successfully connect to db3 at live_server.  This'd defeat the goal
of not letting a script accidentally execute commands against the
wrong database.

Discussion: https://postgr.es/m/38464.1603394584@sss.pgh.pa.us

Files

PathChange+/−
doc/src/sgml/ref/psql-ref.sgml modified +14 −3
src/bin/psql/command.c modified +39 −18
src/bin/psql/common.c modified +7 −3
src/bin/psql/describe.c modified +1 −1
src/bin/psql/settings.h modified +7 −0
src/bin/psql/startup.c modified +5 −1

Documentation touched

Discussion