Fix buffer pin leak in heap update redo routine.

Heikki Linnakangas <heikki.linnakangas@iki.fi>

Commit: 1b315c539134069453379bbd2f306deb6d30af01
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: 2013-03-27T20:05:22Z
Releases: 9.2.4
Fix buffer pin leak in heap update redo routine.

In a heap update, if the old and new tuple were on different pages, and the
new page no longer existed (because it was subsequently truncated away by
vacuum), heap_xlog_update forgot to release the pin on the old buffer. This
bug was introduced by the "Fix multiple problems in WAL replay" patch,
commit 3bbf668de9f1bc172371681e80a4e769b6d014c8 (on master branch).

With full_page_writes=off, this triggered an "incorrect local pin count"
error later in replay, if the old page was vacuumed.

This fixes bug #7969, reported by Yunong Xiao. Backpatch to 9.0, like the
commit that introduced this bug.

Files

PathChange+/−
src/backend/access/heap/heapam.c modified +4 −0