Solve cross-version-upgrade testing problem induced by 1fb57af92.
Tom Lane <tgl@sss.pgh.pa.us>
Solve cross-version-upgrade testing problem induced by 1fb57af92. Renaming varchar_transform to varchar_support had a side effect I hadn't foreseen: the core regression tests leave around a transform object that relies on that function, so the name change breaks cross-version upgrade tests, because the name used in the older branches doesn't match. Since the dependency on varchar_transform was chosen with the aid of a dartboard anyway (it would surely not work as a language transform support function), fix by just choosing a different random builtin function with the right signature. Also add some comments explaining why this isn't horribly unsafe. I chose to make the same substitution in a couple of other copied-and-pasted test cases, for consistency, though those aren't directly contributing to the testing problem. Per buildfarm. Back-patch, else it doesn't fix the problem.
Files
| Path | Change | +/− |
|---|---|---|
| src/test/modules/test_ddl_deparse/expected/create_transform.out | modified | +4 −2 |
| src/test/modules/test_ddl_deparse/sql/create_transform.sql | modified | +4 −2 |
| src/test/regress/expected/object_address.out | modified | +3 −1 |
| src/test/regress/sql/object_address.sql | modified | +3 −1 |