Ensure casting to typmod -1 generates a RelabelType.
Tom Lane <tgl@sss.pgh.pa.us>
Ensure casting to typmod -1 generates a RelabelType. Fix the code changed by commit 5c056b0c2 so that we always generate RelabelType, not something else, for a cast to unspecified typmod. Otherwise planner optimizations might not happen. It appears we missed this point because the previous experiments were done on type numeric: the parser undesirably generates a call on the numeric() length-coercion function, but then numeric_support() optimizes that down to a RelabelType, so that everything seems fine. It misbehaves for types that have a non-optimized length coercion function, such as bpchar. Per report from John Naylor. Back-patch to all supported branches, as the previous patch eventually was. Unfortunately, that no longer includes 9.6 ... we really shouldn't put this type of change into a nearly-EOL branch. Discussion: https://postgr.es/m/CAFBsxsEfbFHEkouc+FSj+3K1sHipLPbEC67L0SAe-9-da8QtYg@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/parser/parse_coerce.c | modified | +9 −1 |
| src/test/regress/expected/expressions.out | modified | +36 −0 |
| src/test/regress/sql/expressions.sql | modified | +16 −0 |
Discussion
- CAST from numeric(18,3) to numeric doesnt work, posgresql 13.3 8 messages · 2021-08-04 → 2021-12-16