Horton

Don't include access/htup_details.h in executor/tuptable.h

Álvaro Herrera <alvherre@kurilemu.de>

View on postgr.es
Commit: 1a8b5b11e48a8fb086228542d1d4b379f23bdc1e
Author: Álvaro Herrera <alvherre@kurilemu.de>
Date: 2025-10-05T16:00:38Z
Releases: 19 (unreleased) 
Don't include access/htup_details.h in executor/tuptable.h

This is not at all needed; I suspect it was a simple mistake in commit
5408e233f066.  It causes htup_details.h to bleed into a huge number of
places via execnodes.h.  Remove it and fix fallout.

Discussion: https://postgr.es/m/202510021240.ptc2zl5cvwen@alvherre.pgsql

Files

PathChange+/−
contrib/pageinspect/btreefuncs.c modified +1 −0
contrib/pageinspect/gistfuncs.c modified +1 −0
contrib/pg_stat_statements/pg_stat_statements.c modified +1 −0
contrib/pg_walinspect/pg_walinspect.c modified +1 −0
contrib/postgres_fdw/connection.c modified +1 −0
contrib/xml2/xslt_proc.c modified +1 −0
src/backend/access/common/printsimple.c modified +1 −0
src/backend/access/common/printtup.c modified +1 −0
src/backend/access/common/tupconvert.c modified +1 −0
src/backend/backup/walsummaryfuncs.c modified +1 −0
src/backend/catalog/pg_attrdef.c modified +1 −0
src/backend/catalog/pg_largeobject.c modified +1 −0
src/backend/catalog/pg_parameter_acl.c modified +1 −0
src/backend/commands/explain_dr.c modified +1 −0
src/backend/commands/proclang.c modified +1 −0
src/backend/commands/statscmds.c modified +1 −0
src/backend/executor/nodeGatherMerge.c modified +1 −0
src/backend/executor/nodeMemoize.c modified +1 −0
src/backend/executor/tstoreReceiver.c modified +1 −0
src/backend/optimizer/path/indxpath.c modified +1 −0
src/backend/optimizer/util/pathnode.c modified +1 −0
src/backend/parser/parse_coerce.c modified +1 −0
src/backend/parser/parse_expr.c modified +1 −0
src/backend/utils/adt/arrayfuncs.c modified +1 −0
src/backend/utils/adt/hbafuncs.c modified +1 −0
src/backend/utils/adt/json.c modified +1 −0
src/backend/utils/adt/misc.c modified +1 −0
src/backend/utils/adt/rangetypes.c modified +1 −0
src/backend/utils/adt/xid8funcs.c modified +1 −0
src/backend/utils/fmgr/fmgr.c modified +1 −0
src/backend/utils/misc/guc.c modified +1 −0
src/include/executor/tuptable.h modified +0 −1
src/test/modules/injection_points/injection_stats_fixed.c modified +1 −0

Discussion