Apply more consistent style for command options in TAP tests

Michael Paquier <michael@paquier.xyz>

Commit: 19c6e92b13b2336d1db1b236457ab15d0894b506
Author: Michael Paquier <michael@paquier.xyz>
Date: 2025-03-17T03:42:23Z
Releases: 18.0
Apply more consistent style for command options in TAP tests

This commit reshapes the grammar of some commands to apply a more
consistent style across the board, following rules similar to
ce1b0f9da03e:
- Elimination of some pointless used-once variables.
- Use of long options, to self-document better the options used.
- Use of fat commas to link option names and their assigned values,
including redirections, so as perltidy can be tricked to put them
together.

Author: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Discussion: https://postgr.es/m/87jz8rzf3h.fsf@wibble.ilmari.org

Files

PathChange+/−
contrib/auto_explain/t/001_auto_explain.pl modified +1 −1
contrib/basebackup_to_shell/t/001_basic.pl modified +4 −2
contrib/sepgsql/t/001_sepgsql.pl modified +1 −2
src/bin/pg_archivecleanup/t/010_pg_archivecleanup.pl modified +5 −4
src/bin/pgbench/t/001_pgbench_with_server.pl modified +1 −1
src/bin/pgbench/t/002_pgbench_no_server.pl modified +1 −1
src/bin/pg_resetwal/t/002_corrupted.pl modified +2 −1
src/bin/pg_rewind/t/009_growing_files.pl modified +1 −2
src/bin/pg_rewind/t/RewindTest.pm modified +12 −9
src/bin/pg_upgrade/t/002_pg_upgrade.pl modified +43 −31
src/bin/pg_upgrade/t/003_logical_slots.pl modified +7 −7
src/bin/pg_upgrade/t/005_char_signedness.pl modified +21 −16
src/bin/pg_verifybackup/t/002_algorithm.pl modified +8 −5
src/bin/pg_verifybackup/t/003_corruption.pl modified +2 −2
src/bin/pg_verifybackup/t/004_options.pl modified +2 −1
src/bin/pg_verifybackup/t/008_untar.pl modified +13 −7
src/bin/pg_verifybackup/t/009_extract.pl modified +14 −11
src/bin/pg_verifybackup/t/010_client_untar.pl modified +11 −6
src/bin/pg_waldump/t/001_basic.pl modified +14 −10
src/bin/psql/t/001_basic.pl modified +3 −2
src/bin/psql/t/020_cancel.pl modified +7 −2
src/interfaces/libpq/t/001_uri.pl modified +3 −2
src/interfaces/libpq/t/005_negotiate_encryption.pl modified +3 −1
src/test/modules/commit_ts/t/003_standby_2.pl modified +1 −1
src/test/modules/libpq_pipeline/t/001_libpq_pipeline.pl modified +2 −2
src/test/modules/ssl_passphrase_callback/t/001_testfunc.pl modified +5 −3
src/test/modules/test_pg_dump/t/001_base.pl modified +94 −65
src/test/perl/PostgreSQL/Test/BackgroundPsql.pm modified +6 −3
src/test/perl/PostgreSQL/Test/Cluster.pm modified +85 −55
src/test/perl/PostgreSQL/Test/Kerberos.pm modified +1 −1
src/test/perl/PostgreSQL/Test/Utils.pm modified +22 −18
src/test/postmaster/t/002_connection_limits.pl modified +3 −2
src/test/recovery/t/001_stream_rep.pl modified +25 −23
src/test/recovery/t/006_logical_decoding.pl modified +5 −2
src/test/recovery/t/013_crash_restart.pl modified +13 −16
src/test/recovery/t/017_shm.pl modified +8 −10
src/test/recovery/t/021_row_visibility.pl modified +16 −14
src/test/recovery/t/022_crash_temp_files.pl modified +14 −16
src/test/recovery/t/032_relfilenode_reuse.pl modified +16 −14
src/test/recovery/t/035_standby_logical_decoding.pl modified +18 −18
src/test/recovery/t/040_standby_failover_slots_sync.pl modified +1 −1
src/test/recovery/t/041_checkpoint_at_promote.pl modified +7 −8
src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl modified +1 −1

Discussion