Horton

Revise GUC names quoting in messages again

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: 17974ec259463869bb6bb4885d46847422fbc9ec
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2024-05-17T09:44:26Z
Releases: 17.0 
Revise GUC names quoting in messages again

After further review, we want to move in the direction of always
quoting GUC names in error messages, rather than the previous (PG16)
wildly mixed practice or the intermittent (mid-PG17) idea of doing
this depending on how possibly confusing the GUC name is.

This commit applies appropriate quotes to (almost?) all mentions of
GUC names in error messages.  It partially supersedes a243569bf65 and
8d9978a7176, which had moved things a bit in the opposite direction
but which then were abandoned in a partial state.

Author: Peter Smith <smithpb2250@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CAHut%2BPv-kSN8SkxSdoHano_wPubqcg5789ejhCDZAcLFceBR-w%40mail.gmail.com

Files

PathChange+/−
contrib/pg_prewarm/autoprewarm.c modified +2 −2
contrib/pg_stat_statements/pg_stat_statements.c modified +3 −3
contrib/sepgsql/hooks.c modified +1 −1
contrib/test_decoding/expected/slot.out modified +1 −1
doc/src/sgml/sources.sgml modified +4 −11
src/backend/access/gin/ginbulk.c modified +1 −1
src/backend/access/heap/vacuumlazy.c modified +1 −1
src/backend/access/table/tableamapi.c modified +2 −2
src/backend/access/transam/commit_ts.c modified +2 −2
src/backend/access/transam/multixact.c modified +2 −2
src/backend/access/transam/rmgr.c modified +2 −2
src/backend/access/transam/twophase.c modified +3 −3
src/backend/access/transam/xlogarchive.c modified +1 −1
src/backend/access/transam/xlog.c modified +13 −13
src/backend/access/transam/xlogfuncs.c modified +2 −2
src/backend/access/transam/xlogprefetcher.c modified +1 −1
src/backend/access/transam/xlogrecovery.c modified +6 −6
src/backend/commands/publicationcmds.c modified +2 −2
src/backend/commands/vacuum.c modified +1 −1
src/backend/commands/variable.c modified +4 −4
src/backend/libpq/be-secure-openssl.c modified +2 −2
src/backend/libpq/hba.c modified +1 −1
src/backend/libpq/pqcomm.c modified +1 −1
src/backend/parser/scan.l modified +1 −1
src/backend/port/sysv_sema.c modified +1 −1
src/backend/port/sysv_shmem.c modified +4 −4
src/backend/port/win32_shmem.c modified +1 −1
src/backend/postmaster/bgworker.c modified +1 −1
src/backend/postmaster/checkpointer.c modified +1 −1
src/backend/postmaster/pgarch.c modified +5 −5
src/backend/postmaster/postmaster.c modified +5 −5
src/backend/replication/logical/decode.c modified +1 −1
src/backend/replication/logical/launcher.c modified +2 −2
src/backend/replication/logical/logical.c modified +2 −2
src/backend/replication/logical/origin.c modified +4 −4
src/backend/replication/slot.c modified +10 −10
src/backend/replication/syncrep.c modified +1 −1
src/backend/storage/buffer/localbuf.c modified +1 −1
src/backend/storage/file/fd.c modified +4 −4
src/backend/storage/lmgr/lock.c modified +6 −6
src/backend/storage/lmgr/predicate.c modified +6 −6
src/backend/storage/lmgr/proc.c modified +1 −1
src/backend/tcop/postgres.c modified +6 −6
src/backend/utils/adt/pg_locale.c modified +2 −2
src/backend/utils/adt/varlena.c modified +1 −1
src/backend/utils/fmgr/dfmgr.c modified +2 −2
src/backend/utils/misc/guc.c modified +1 −1
src/backend/utils/misc/guc_tables.c modified +12 −12
src/bin/initdb/initdb.c modified +2 −2
src/bin/pg_basebackup/streamutil.c modified +3 −3
src/bin/pgbench/pgbench.c modified +1 −1
src/bin/pg_controldata/pg_controldata.c modified +1 −1
src/bin/pg_dump/pg_backup_archiver.c modified +3 −3
src/bin/pg_dump/pg_dump.c modified +2 −2
src/bin/pg_rewind/libpq_source.c modified +2 −2
src/bin/pg_rewind/pg_rewind.c modified +3 −3
src/bin/pg_test_fsync/pg_test_fsync.c modified +1 −1
src/bin/pg_upgrade/check.c modified +3 −3
src/bin/pg_upgrade/t/003_logical_slots.pl modified +2 −2
src/bin/pg_upgrade/t/004_subscription.pl modified +1 −1
src/fe_utils/archive.c modified +1 −1
src/interfaces/libpq/fe-auth.c modified +1 −1
src/interfaces/libpq/fe-connect.c modified +2 −2
src/test/modules/commit_ts/expected/commit_timestamp_1.out modified +6 −6
src/test/modules/libpq_pipeline/libpq_pipeline.c modified +2 −2
src/test/modules/ssl_passphrase_callback/ssl_passphrase_func.c modified +1 −1
src/test/modules/ssl_passphrase_callback/t/001_testfunc.pl modified +1 −1
src/test/modules/test_shm_mq/setup.c modified +1 −1
src/test/modules/test_slru/test_slru.c modified +1 −1
src/test/recovery/t/024_archive_recovery.pl modified +2 −2
src/test/recovery/t/035_standby_logical_decoding.pl modified +1 −1
src/test/regress/expected/collate.icu.utf8.out modified +2 −2
src/test/regress/expected/create_am.out modified +1 −1
src/test/regress/expected/jsonb.out modified +2 −2
src/test/regress/expected/json.out modified +2 −2
src/test/regress/expected/prepared_xacts_1.out modified +9 −9
src/test/regress/expected/strings.out modified +6 −6
src/test/ssl/t/001_ssltests.pl modified +2 −2
src/test/subscription/t/001_rep_changes.pl modified +2 −2

Documentation touched

Discussion