Horton

Replace remaining StrNCpy() by strlcpy()

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: 1784f278a63866cc144fcd0a2127cadba6a2b7f8
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2020-08-10T21:20:37Z
Releases: 14.0 
Replace remaining StrNCpy() by strlcpy()

They are equivalent, except that StrNCpy() zero-fills the entire
destination buffer instead of providing just one trailing zero.  For
all but a tiny number of callers, that's just overhead rather than
being desirable.

Remove StrNCpy() as it is now unused.

In some cases, namestrcpy() is the more appropriate function to use.
While we're here, simplify the API of namestrcpy(): Remove the return
value, don't check for NULL input.  Nothing was using that anyway.
Also, remove a few unused name-related functions.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/44f5e198-36f6-6cdb-7fa9-60e34784daae%402ndquadrant.com

Files

PathChange+/−
contrib/pgcrypto/crypt-des.c modified +1 −1
src/backend/access/transam/slru.c modified +1 −1
src/backend/access/transam/xlogarchive.c modified +1 −1
src/backend/catalog/pg_constraint.c modified +1 −1
src/backend/commands/indexcmds.c modified +1 −1
src/backend/commands/statscmds.c modified +1 −1
src/backend/commands/tablecmds.c modified +1 −1
src/backend/postmaster/pgstat.c modified +1 −1
src/backend/replication/logical/logical.c modified +9 −2
src/backend/replication/slot.c modified +1 −1
src/backend/utils/adt/formatting.c modified +4 −4
src/backend/utils/adt/name.c modified +4 −44
src/backend/utils/adt/pg_locale.c modified +0 −9
src/backend/utils/adt/ruleutils.c modified +1 −1
src/common/exec.c modified +2 −2
src/include/c.h modified +0 −29
src/include/utils/builtins.h modified +1 −2
src/interfaces/ecpg/pgtypeslib/dt_common.c modified +2 −2
src/interfaces/ecpg/test/pg_regress_ecpg.c modified +1 −1
src/test/modules/ssl_passphrase_callback/ssl_passphrase_func.c modified +1 −1

Discussion