Horton

Fix NO ACTION temporal foreign keys when the referenced endpoints change

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: 1772d554b089c4779eaa13ae1487721e3080d119
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2025-01-21T13:39:24Z
Releases: 18.0 
Fix NO ACTION temporal foreign keys when the referenced endpoints change

If a referenced UPDATE changes the temporal start/end times, shrinking
the span the row is valid, we get a false return from
ri_Check_Pk_Match(), but overlapping references may still be valid, if
their reference didn't overlap with the removed span.

We need to consider what span(s) are still provided in the referenced
table.  Instead of returning that from ri_Check_Pk_Match(), we can
just look it up in the main SQL query.

Reported-by: Sam Gabrielsson <sam@movsom.se>
Author: Paul Jungwirth <pj@illuminatedcomputing.com>
Discussion: https://www.postgresql.org/message-id/flat/CA+renyUApHgSZF9-nd-a0+OPGharLQLO=mDHcY4_qQ0+noCUVg@mail.gmail.com

Files

PathChange+/−
src/backend/catalog/pg_constraint.c modified +16 −1
src/backend/commands/tablecmds.c modified +3 −1
src/backend/utils/adt/ri_triggers.c modified +92 −2
src/include/catalog/pg_constraint.h modified +2 −1
src/include/catalog/pg_operator.dat modified +4 −2
src/test/regress/expected/without_overlaps.out modified +62 −0
src/test/regress/sql/without_overlaps.sql modified +54 −0

Discussion