Fix O(N^2) performance issue in pg_publication_tables view.
Tom Lane <tgl@sss.pgh.pa.us>
Fix O(N^2) performance issue in pg_publication_tables view. The original coding of this view relied on a correlated IN sub-query. Our planner is not very bright about correlated sub-queries, and even if it were, there's no way for it to know that the output of pg_get_publication_tables() is duplicate-free, making the de-duplicating semantics of IN unnecessary. Hence, rewrite as a LATERAL sub-query. This provides circa 100X speedup for me with a few hundred published tables (the whole regression database), and things would degrade as roughly O(published_relations * all_relations) beyond that. Because the rules.out expected output changes, force a catversion bump. Ordinarily we might not want to do that post-beta1; but we already know we'll be doing a catversion bump before beta2 to fix pg_statistic_ext issues, so it's pretty much free to fix it now instead of waiting for v13. Per report and fix suggestion from PegoraroF10. Discussion: https://postgr.es/m/1551385426763-0.post@n3.nabble.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/catalog/system_views.sql | modified | +4 −3 |
| src/include/catalog/catversion.h | modified | +1 −1 |
| src/test/regress/expected/rules.out | modified | +2 −2 |
Discussion
- Refresh Publication takes hours and doesn´t finish 14 messages · 2019-02-28 → 2019-05-23