Cosmetic improvements in setup of planner's per-RTE arrays.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 1661a4050593a472c369a6660ffec05b6b837c57
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2019-08-09T16:33:43Z
Releases: 13.0
Cosmetic improvements in setup of planner's per-RTE arrays.

Merge setup_append_rel_array into setup_simple_rel_arrays.  There's no
particularly good reason to keep them separate, and it's inconsistent
with the lack of separation in expand_planner_arrays.  The only apparent
benefit was that the fast path for trivial queries in query_planner()
doesn't need to set up the append_rel_array; but all we're saving there
is an if-test and NULL assignment, which surely ought to be negligible.

Also improve some obsolete comments.

Discussion: https://postgr.es/m/17220.1565301350@sss.pgh.pa.us

Files

Discussion