Cosmetic improvements in setup of planner's per-RTE arrays.
Tom Lane <tgl@sss.pgh.pa.us>
Cosmetic improvements in setup of planner's per-RTE arrays. Merge setup_append_rel_array into setup_simple_rel_arrays. There's no particularly good reason to keep them separate, and it's inconsistent with the lack of separation in expand_planner_arrays. The only apparent benefit was that the fast path for trivial queries in query_planner() doesn't need to set up the append_rel_array; but all we're saving there is an if-test and NULL assignment, which surely ought to be negligible. Also improve some obsolete comments. Discussion: https://postgr.es/m/17220.1565301350@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/optimizer/plan/planmain.c | modified | +1 −9 |
| src/backend/optimizer/prep/prepunion.c | modified | +1 −7 |
| src/backend/optimizer/util/relnode.c | modified | +28 −25 |
| src/include/nodes/pathnodes.h | modified | +4 −5 |
| src/include/optimizer/pathnode.h | modified | +0 −1 |
Discussion
- POC: converting Lists into arrays 137 messages · 2019-02-24 → 2021-03-09