Fix bogus logic for checking data dirs' versions within pg_upgrade.
Tom Lane <tgl@sss.pgh.pa.us>
Fix bogus logic for checking data dirs' versions within pg_upgrade. Commit 9be95ef15 failed to cure all of the redundancy here: we were actually calling get_major_server_version() three times for each of the old and new data directories. While that's not enormously expensive, it's still sloppy. A. Akenteva Discussion: https://postgr.es/m/f9266a85d918a3cf3a386b5148aee666@postgrespro.ru
Files
| Path | Change | +/− |
|---|---|---|
| src/bin/pg_upgrade/check.c | modified | +3 −3 |
| src/bin/pg_upgrade/exec.c | modified | +2 −3 |
Discussion
- A weird bit in pg_upgrade/exec.c 6 messages · 2017-11-09 → 2017-11-16