Absorb -D_USE_32BIT_TIME_T switch from Perl, if relevant.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 1621a75531c873e48b6edd370ba70d020cbec538
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-08-14T15:48:59Z
Releases: 9.5.9
Absorb -D_USE_32BIT_TIME_T switch from Perl, if relevant.

Commit 3c163a7fc's original choice to ignore all #define symbols whose
names begin with underscore turns out to be too simplistic.  On Windows,
some Perl installations are built with -D_USE_32BIT_TIME_T, and we must
absorb that or we get the wrong result for sizeof(PerlInterpreter).

This effectively re-reverts commit ef58b87df, which injected that symbol
in a hacky way, making it apply to all of Postgres not just PL/Perl.
More significantly, it did so on *all* 32-bit Windows builds, even when
the Perl build to be used did not select this option; so that it fails
to work properly with some newer Perl builds.

By making this change, we would be introducing an ABI break in 32-bit
Windows builds; but fortunately we have not used type time_t in any
exported Postgres APIs in a long time.  So it should be OK, both for
PL/Perl itself and for third-party extensions, if an extension library
is built with a different _USE_32BIT_TIME_T setting than the core code.

Patch by me, based on research by Ashutosh Sharma and Robert Haas.
Back-patch to all supported branches, as commit 3c163a7fc was.

Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com

Files

PathChange+/−
config/perl.m4 modified +4 −2
configure modified +1 −1
src/tools/msvc/Mkvcbuild.pm modified +3 −2
src/tools/msvc/MSBuildProject.pm modified +2 −7
src/tools/msvc/VCBuildProject.pm modified +2 −8

Discussion