Make ginbuild's funcCtx be independent of its tmpCtx.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 1601830ec20d56dc7bf6b60a34f69841429e4825
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2015-03-29T18:02:58Z
Releases: 9.5.0
Make ginbuild's funcCtx be independent of its tmpCtx.

Previously the funcCtx was a child of the tmpCtx, but that was broken
by commit eaa5808e8ec4e82ce1a87103a6b6f687666e4e4c, which made
MemoryContextReset() delete, not reset, child contexts.  The behavior of
having a tmpCtx reset also clear the other context seems rather dubious
anyway, so let's just disentangle them.  Per report from Erik Rijkers.

In passing, fix badly-inaccurate comments about these contexts.

Files

PathChange+/−
src/backend/access/gin/gininsert.c modified +8 −3