Horton

Rewrite comments in replication slot advance implementation

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: 1573995f55994ee04dd0d69481de17d662ad8e88
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2018-07-19T18:15:44Z
Releases: 12.0 
Rewrite comments in replication slot advance implementation

The code added by 9c7d06d60680 was a bit obscure; clarify that by
rewriting the comments.  Lack of clarity has already caused bugs, so
it's a worthy goal.

Co-authored-by: Arseny Sher <a.sher@postgrespro.ru>
Co-authored-by: Michaël Paquier <michael@paquier.xyz>
Co-authored-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reviewed-by: Petr Jelínek <petr.jelinek@2ndquadrant.com>
Discussion: https://postgr.es/m/87y3fgoyrn.fsf@ars-thinkpad

Files

PathChange+/−
src/backend/replication/logical/logical.c modified +4 −1
src/backend/replication/slotfuncs.c modified +46 −26

Discussion