For inplace update durability, make heap_update() callers wait.
Noah Misch <noah@leadboat.com>
For inplace update durability, make heap_update() callers wait. The previous commit fixed some ways of losing an inplace update. It remained possible to lose one when a backend working toward a heap_update() copied a tuple into memory just before inplace update of that tuple. In catalogs eligible for inplace update, use LOCKTAG_TUPLE to govern admission to the steps of copying an old tuple, modifying it, and issuing heap_update(). This includes MERGE commands. To avoid changing most of the pg_class DDL, don't require LOCKTAG_TUPLE when holding a relation lock sufficient to exclude inplace updaters. Back-patch to v12 (all supported versions). In v13 and v12, "UPDATE pg_class" or "UPDATE pg_database" can still lose an inplace update. The v14+ UPDATE fix needs commit 86dc90056dfdbd9d1b891718d2e5614e3e432f35, and it wasn't worth reimplementing that fix without such infrastructure. Reviewed by Nitin Motiani and (in earlier versions) Heikki Linnakangas. Discussion: https://postgr.es/m/20231027214946.79.nmisch@google.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/heap/heapam.c | modified | +149 −1 |
| src/backend/access/heap/README.tuplock | modified | +42 −0 |
| src/backend/access/index/genam.c | modified | +3 −1 |
| src/backend/catalog/aclchk.c | modified | +7 −2 |
| src/backend/catalog/catalog.c | modified | +9 −0 |
| src/backend/commands/dbcommands.c | modified | +12 −2 |
| src/backend/commands/indexcmds.c | modified | +5 −2 |
| src/backend/commands/tablecmds.c | modified | +21 −7 |
| src/backend/executor/execReplication.c | modified | +6 −1 |
| src/backend/executor/nodeModifyTable.c | modified | +26 −0 |
| src/backend/utils/cache/relcache.c | modified | +6 −3 |
| src/backend/utils/cache/syscache.c | modified | +117 −0 |
| src/include/storage/lockdefs.h | modified | +2 −0 |
| src/include/utils/syscache.h | modified | +5 −0 |
| src/test/isolation/expected/intra-grant-inplace.out | modified | +7 −7 |
| src/test/isolation/specs/eval-plan-qual.spec | modified | +1 −1 |
| src/test/isolation/specs/intra-grant-inplace.spec | modified | +5 −7 |
Discussion
- race condition in pg_class 86 messages · 2023-10-25 → 2026-02-16