Reduce excessive dereferencing of function pointers

Peter Eisentraut <peter_e@gmx.net>

Commit: 1356f78ea93395c107cbc75dc923e29a0efccd8a
Author: Peter Eisentraut <peter_e@gmx.net>
Date: 2017-09-07T17:56:09Z
Releases: 11.0
Reduce excessive dereferencing of function pointers

It is equivalent in ANSI C to write (*funcptr) () and funcptr().  These
two styles have been applied inconsistently.  After discussion, we'll
use the more verbose style for plain function pointer variables, to make
it clear that it's a variable, and the shorter style when the function
pointer is in a struct (s.func() or s->func()), because then it's clear
that it's not a plain function name, and otherwise the excessive
punctuation makes some of those invocations hard to read.

Discussion: https://www.postgresql.org/message-id/f52c16db-14ed-757d-4b48-7ef360b1631d@2ndquadrant.com

Files

PathChange+/−
contrib/btree_gist/btree_utils_num.c modified +17 −17
contrib/btree_gist/btree_utils_var.c modified +22 −22
src/backend/access/transam/xact.c modified +2 −2
src/backend/commands/analyze.c modified +2 −2
src/backend/commands/portalcmds.c modified +1 −1
src/backend/commands/seclabel.c modified +1 −1
src/backend/executor/execCurrent.c modified +1 −1
src/backend/executor/execExprInterp.c modified +9 −9
src/backend/executor/execMain.c modified +3 −3
src/backend/executor/execParallel.c modified +1 −1
src/backend/executor/execTuples.c modified +3 −3
src/backend/executor/execUtils.c modified +1 −1
src/backend/executor/functions.c modified +1 −1
src/backend/nodes/params.c modified +3 −3
src/backend/parser/parse_coerce.c modified +1 −1
src/backend/parser/parse_expr.c modified +5 −5
src/backend/parser/parse_target.c modified +2 −2
src/backend/rewrite/rewriteManip.c modified +1 −1
src/backend/storage/ipc/ipc.c modified +6 −6
src/backend/storage/smgr/smgr.c modified +22 −22
src/backend/tcop/postgres.c modified +2 −2
src/backend/tcop/pquery.c modified +4 −4
src/backend/utils/adt/array_typanalyze.c modified +1 −1
src/backend/utils/adt/expandeddatum.c modified +2 −2
src/backend/utils/adt/jsonfuncs.c modified +2 −2
src/backend/utils/cache/inval.c modified +4 −4
src/backend/utils/error/elog.c modified +2 −2
src/backend/utils/mb/mbutils.c modified +8 −8
src/backend/utils/mb/wchar.c modified +6 −6
src/backend/utils/misc/guc.c modified +30 −30
src/backend/utils/misc/timeout.c modified +1 −1
src/backend/utils/mmgr/mcxt.c modified +19 −20
src/backend/utils/mmgr/portalmem.c modified +5 −5
src/backend/utils/mmgr/README modified +1 −1
src/backend/utils/resowner/resowner.c modified +1 −1
src/bin/pg_dump/pg_backup_archiver.c modified +42 −42
src/bin/pg_dump/pg_backup_null.c modified +1 −1
src/bin/pg_dump/pg_backup_utils.c modified +2 −2
src/bin/psql/variables.c modified +2 −2
src/include/executor/executor.h modified +2 −2
src/include/utils/selfuncs.h modified +1 −1
src/include/utils/sortsupport.h modified +2 −2
src/interfaces/libpq/fe-connect.c modified +2 −2
src/interfaces/libpq/fe-exec.c modified +1 −1
src/interfaces/libpq/fe-protocol2.c modified +1 −1
src/interfaces/libpq/fe-protocol3.c modified +1 −1

Discussion