postgres_fdw: Fix handling of abort-cleanup-failed connections.
Etsuro Fujita <efujita@postgresql.org>
postgres_fdw: Fix handling of abort-cleanup-failed connections. As connections that failed abort cleanup can't safely be further used, if a remote query tries to get such a connection, we reject it. Previously, this rejection involved dropping the connection if it was open, without accounting for the possibility of open cursors using it, causing a server crash when such an open cursor tried to use an already-dropped connection, as a cursor-handling function (create_cursor, fetch_more_data, or close_cursor) was called on a freed PGconn. To fix, delay dropping failed connections until abort cleanup of the main transaction, to ensure open cursors using such a connection can safely refer to the PGconn for it. Oversight in commit 8bf58c0d9. Reported-by: Zhibai Song <songzhibai1234@gmail.com> Diagnosed-by: Zhibai Song <songzhibai1234@gmail.com> Author: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com> Discussion: https://postgr.es/m/CAPmGK176y6JP017-Cn%2BhS9CEJx_6iVhRoYbAqzuLU4d8-XPPNg%40mail.gmail.com Backpatch-through: 14
Files
| Path | Change | +/− |
|---|---|---|
| contrib/postgres_fdw/connection.c | modified | +6 −4 |
| contrib/postgres_fdw/expected/postgres_fdw.out | modified | +76 −0 |
| contrib/postgres_fdw/sql/postgres_fdw.sql | modified | +51 −0 |
Discussion
- Use-after-free issue in postgres_fdw 13 messages · 2026-03-19 → 2026-05-05