Fix race in SSI interaction with gin fast path.

Thomas Munro <tmunro@postgresql.org>

Commit: 12529028a4e55eb0500477d2589eec625466facf
Author: Thomas Munro <tmunro@postgresql.org>
Date: 2023-07-03T21:04:35Z
Releases: 16.0
Fix race in SSI interaction with gin fast path.

The ginfast.c code previously checked for conflicts in before locking
the relevant buffer, leaving a window where a RW conflict could be
missed.  Re-order.

There was also a place where buffer ID and block number were confused
while trying to predicate-lock a page, noted by visual inspection.

Back-patch to all supported releases.  Fixes one more problem discovered
with the reproducer from bug #17949, in this case when Dmitry tried
other index types.

Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com>
Reported-by: Dmitry Dolgov <9erthalion6@gmail.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org

Files

PathChange+/−
src/backend/access/gin/ginfast.c modified +7 −2
src/backend/access/gin/ginget.c modified +3 −1

Discussion