Don't leak malloc'd error string in libpqrcv_check_conninfo().

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 12354839e874c1f6ebc5e1e5ebc1c6b5519eeea0
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-03-19T02:21:58Z
Releases: 13.3
Don't leak malloc'd error string in libpqrcv_check_conninfo().

We leaked the error report from PQconninfoParse, when there was
one.  It seems unlikely that real usage patterns would repeat
the failure often enough to create serious bloat, but let's
back-patch anyway to keep the code similar in all branches.

Found via valgrind testing.
Back-patch to v10 where this code was added.

Discussion: https://postgr.es/m/3816764.1616104288@sss.pgh.pa.us

Files

Discussion