Inline initial comparisons in TestForOldSnapshot()

Kevin Grittner <kgrittn@postgresql.org>

Commit: 11e178d0dc4bc2328ae4759090b3c48b07023fab
Author: Kevin Grittner <kgrittn@postgresql.org>
Date: 2016-04-21T13:40:08Z
Releases: 9.6.0
Inline initial comparisons in TestForOldSnapshot()

Even with old_snapshot_threshold = -1 (which disables the "snapshot
too old" feature), performance regressions were seen at moderate to
high concurrency.  For example, a one-socket, four-core system
running 200 connections at saturation could see up to a 2.3%
regression, with larger regressions possible on NUMA machines.
By inlining the early (smaller, faster) tests in the
TestForOldSnapshot() function, the i7 case dropped to a 0.2%
regression, which could easily just be noise, and is clearly an
improvement.  Further testing will show whether more is needed.

Files

PathChange+/−
src/backend/storage/buffer/bufmgr.c modified +5 −23
src/include/storage/bufmgr.h modified +31 −1