Horton

Fix incorrect return value in JSON equality function for scalars

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 1171dbde2daef8f0dcd1dc1e54531a0d8dd34d88
Author: Michael Paquier <michael@paquier.xyz>
Date: 2019-05-13T00:11:50Z
Releases: 12.0 
Fix incorrect return value in JSON equality function for scalars

equalsJsonbScalarValue() uses a boolean as return type, however for one
code path -1 gets returned, which is confusing.  The origin of the
confusion is visibly that this code got copy-pasted from
compareJsonbScalarValue() since it has been introduced in d1d50bf.

No backpatch, as this is only cosmetic.

Author: Rikard Falkeborn
Discussion: https://postgr.es/m/CADRDgG7mJnek6HNW13f+LF6V=6gag9PM+P7H5dnyWZAv49aBGg@mail.gmail.com

Files

PathChange+/−
src/backend/utils/adt/jsonb_util.c modified +1 −1

Discussion