Fix finalization for json_objectagg and friends

Andrew Dunstan <andrew@dunslane.net>

Commit: 112fdb3528465cc14a2f1dff3dc27f100326d885
Author: Andrew Dunstan <andrew@dunslane.net>
Date: 2022-04-13T14:37:43Z
Releases: 15.0
Fix finalization for json_objectagg and friends

Commit f4fb45d15c misguidedly tried to free some state during aggregate
finalization for json_objectagg. This resulted in attempts to access
freed memory, especially when the function is used as a window function.
Commit 4eb9798879 attempted to ameliorate that, but in fact it should
just be ripped out, which is done here. Also add some regression tests
for json_objectagg in various flavors as a window function.

Original report from Jaime Casanova, diagnosis by Andres Freund.

Discussion: https://postgr.es/m/YkfeMNYRCGhySKyg@ahch-to

Files

Discussion