Add optional parameter to PG_TRY() macros
David Rowley <drowley@postgresql.org>
Add optional parameter to PG_TRY() macros This optional parameter can be specified in cases where there are nested PG_TRY() statements within a function in order to stop the compiler from issuing warnings about shadowed local variables when compiling with -Wshadow. The optional parameter is used as a suffix on the variable names declared within the PG_TRY(), PG_CATCH(), PG_FINALLY() and PG_END_TRY() macros. The parameter, if specified, must be the same in each component macro of the given PG_TRY() block. This also adjusts the single case where we have nested PG_TRY() statements to add a parameter to the inner-most PG_TRY(). This reduces the number of compiler warnings when compiling with -Wshadow=compatible-local from 5 down to 1. Author: David Rowley Discussion: https://postgr.es/m/CAApHDvqWGMdB_pATeUqE=JCtNqNxObPOJ00jFEa2_sZ20j_Wvg@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/tcop/utility.c | modified | +3 −3 |
| src/include/utils/elog.h | modified | +26 −18 |
Discussion
- shadow variables - pg15 edition 56 messages · 2022-08-17 → 2022-10-12