Refactor the handling of the various DropStmt variants so that when multiple

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 0cefb50f3ce964d6097aad64dabd9b544c3d2e68

Author: Tom Lane <tgl@sss.pgh.pa.us>

Date: 2008-06-14T18:04:34Z

Refactor the handling of the various DropStmt variants so that when multiple
objects are specified, we drop them all in a single performMultipleDeletions
call.  This makes the RESTRICT/CASCADE checks more relaxed: it's not counted
as a cascade if one of the later objects has a dependency on an earlier one.
NOTICE messages about such cases go away, too.

In passing, fix the permissions check for DROP CONVERSION, which for some
reason was never made role-aware, and omitted the namespace-owner exemption
too.

Alex Hunsaker, with further fiddling by me.

Files

Path	Change	+/−
src/backend/catalog/dependency.c	modified	+9 −2
src/backend/catalog/pg_conversion.c	modified	+1 −36
src/backend/commands/conversioncmds.c	modified	+60 −18
src/backend/commands/indexcmds.c	modified	+1 −29
src/backend/commands/schemacmds.c	modified	+57 −38
src/backend/commands/tablecmds.c	modified	+212 −11
src/backend/commands/tsearchcmds.c	modified	+185 −111
src/backend/commands/typecmds.c	modified	+72 −114
src/backend/commands/view.c	modified	+1 −25
src/backend/tcop/utility.c	modified	+40 −242
src/include/catalog/pg_conversion_fn.h	modified	+1 −4
src/include/commands/conversioncmds.h	modified	+2 −3
src/include/commands/defrem.h	modified	+5 −10
src/include/commands/schemacmds.h	modified	+2 −2
src/include/commands/tablecmds.h	modified	+2 −2
src/include/commands/typecmds.h	modified	+2 −3
src/include/commands/view.h	modified	+1 −2
src/test/regress/expected/foreign_key.out	modified	+2 −13
src/test/regress/expected/truncate.out	modified	+0 −6
src/test/regress/sql/foreign_key.sql	modified	+2 −2