Initialize ListenSocket array earlier.

Heikki Linnakangas <heikki.linnakangas@iki.fi>

Commit: 0c10240600ad3d7a139737467184777ea822f593
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: 2023-08-29T06:12:35Z
Releases: 15.5
Initialize ListenSocket array earlier.

After commit b0bea38705, syslogger prints 63 warnings about failing to
close a listen socket at postmaster startup. That's because the
syslogger process forks before the ListenSockets array is initialized,
so ClosePostmasterPorts() calls "close(0)" 64 times. The first call
succeeds, because fd 0 is stdin.

This has been like this since commit 9a86f03b4e in version 13, which
moved the SysLogger_Start() call to before initializing ListenSockets.
We just didn't notice until commit b0bea38705 added the LOG message.

Reported by Michael Paquier and Jeff Janes.

Author: Michael Paquier
Discussion: https://www.postgresql.org/message-id/ZOvvuQe0rdj2slA9%40paquier.xyz
Discussion: https://www.postgresql.org/message-id/ZO0fgDwVw2SUJiZx@paquier.xyz#482670177eb4eaf4c9f03c1eed963e5f
Backpatch-through: 13

Files

PathChange+/−
src/backend/postmaster/postmaster.c modified +11 −8

Discussion

Cited messages not in the archive: ZO0fgDwVw2SUJiZx@paquier.xyz#482670177eb4eaf4c9f03c1eed963e5f