Add comments warning against generalizing default_with_oids.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 0bd11d9711b88e72d2022e25b9227c480aca4978
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2015-04-26T01:38:06Z
Releases: 9.5.0
Add comments warning against generalizing default_with_oids.

pg_dump has historically assumed that default_with_oids affects only plain
tables and not other relkinds.  Conceivably we could make it apply to some
newly invented relkind if we did so from the get-go, but changing the
behavior for existing object types will break existing dump scripts.
Add code comments warning about this interaction.

Also, make sure that default_with_oids doesn't cause parse_utilcmd.c to
think that CREATE FOREIGN TABLE will create an OID column.  I think this is
only a latent bug right now, since we don't allow UNIQUE/PKEY constraints
in CREATE FOREIGN TABLE, but it's better to be consistent and future-proof.

Files

PathChange+/−
src/backend/commands/tablecmds.c modified +8 −0
src/backend/parser/parse_utilcmd.c modified +12 −1