Horton

Fix CREATE VIEW to allow zero-column views.

Tom Lane <tgl@sss.pgh.pa.us>

View on postgr.es
Commit: 0b476cf623dd5849679d4509f6b06b8be7f3436e
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2019-02-17T17:37:32Z
Releases: 9.5.17 
Fix CREATE VIEW to allow zero-column views.

We should logically have allowed this case when we allowed zero-column
tables, but it was overlooked.

Although this might be thought a feature addition, it's really a bug
fix, because it was possible to create a zero-column view via
the convert-table-to-view code path, and then you'd have a situation
where dump/reload would fail.  Hence, back-patch to all supported
branches.

Arrange the added test cases to provide coverage of the related
pg_dump code paths (since these views will be dumped and reloaded
during the pg_upgrade regression test).  I also made them test
the case where pg_dump has to postpone the view rule into post-data,
which disturbingly had no regression coverage before.

Report and patch by Ashutosh Sharma (test case by me)

Discussion: https://postgr.es/m/CAE9k0PkmHdeSaeZt2ujnb_cKucmK3sDDceDzw7+d5UZoNJPYOg@mail.gmail.com

Files

PathChange+/−
src/backend/commands/view.c modified +0 −5
src/test/regress/expected/create_view.out modified +10 −0
src/test/regress/expected/rules.out modified +8 −0
src/test/regress/expected/sanity_check.out modified +1 −0
src/test/regress/sql/create_view.sql modified +12 −0

Discussion