Remove the recently added node types ReloptElem and OptionDefElem in favor
Tom Lane <tgl@sss.pgh.pa.us>
Remove the recently added node types ReloptElem and OptionDefElem in favor of adding optional namespace and action fields to DefElem. Having three node types that do essentially the same thing bloats the code and leads to errors of confusion, such as in yesterday's bug report from Khee Chin.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/common/reloptions.c | modified | +21 −21 |
| src/backend/commands/define.c | modified | +31 −65 |
| src/backend/commands/foreigncmds.c | modified | +33 −38 |
| src/backend/commands/sequence.c | modified | +2 −2 |
| src/backend/commands/typecmds.c | modified | +2 −2 |
| src/backend/commands/view.c | modified | +2 −2 |
| src/backend/nodes/copyfuncs.c | modified | +3 −30 |
| src/backend/nodes/equalfuncs.c | modified | +3 −26 |
| src/backend/nodes/makefuncs.c | modified | +17 −17 |
| src/backend/nodes/outfuncs.c | modified | +3 −14 |
| src/backend/parser/gram.y | modified | +58 −58 |
| src/backend/parser/parse_clause.c | modified | +6 −5 |
| src/include/commands/defrem.h | modified | +2 −4 |
| src/include/foreign/foreign.h | modified | +2 −8 |
| src/include/nodes/makefuncs.h | modified | +3 −5 |
| src/include/nodes/nodes.h | modified | +1 −3 |
| src/include/nodes/parsenodes.h | modified | +19 −33 |