Do parse analysis of an EXPLAIN's contained statement during the normal
Tom Lane <tgl@sss.pgh.pa.us>
Do parse analysis of an EXPLAIN's contained statement during the normal parse analysis phase, rather than at execution time. This makes parameter handling work the same as it does in ordinary plannable queries, and in particular fixes the incompatibility that Pavel pointed out with plpgsql's new handling of variable references. plancache.c gets a little bit grottier, but the alternatives seem worse.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/commands/explain.c | modified | +9 −8 |
| src/backend/nodes/params.c | modified | +1 −45 |
| src/backend/optimizer/plan/setrefs.c | modified | +19 −5 |
| src/backend/parser/analyze.c | modified | +11 −23 |
| src/backend/tcop/utility.c | modified | +2 −1 |
| src/backend/utils/cache/plancache.c | modified | +90 −38 |
| src/include/nodes/params.h | modified | +1 −4 |
| src/include/nodes/parsenodes.h | modified | +6 −2 |
| src/include/optimizer/planmain.h | modified | +2 −2 |