Avoid possible longjmp-induced logic error in PLy_trigger_build_args.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 08bdf0a4798bbbbc401bd951cd9553f3c6de2de7
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2024-04-01T19:15:03Z
Releases: 15.7
Avoid possible longjmp-induced logic error in PLy_trigger_build_args.

The "pltargs" variable wasn't marked volatile, which makes it unsafe
to change its value within the PG_TRY block.  It looks like the worst
outcome would be to fail to release a refcount on Py_None during an
(improbable) error exit, which would likely go unnoticed in the field.
Still, it's a bug.  A one-liner fix could be to mark pltargs volatile,
but on the whole it seems cleaner to arrange things so that we don't
change its value within PG_TRY.

Per report from Xing Guo.  This has been there for quite awhile,
so back-patch to all supported branches.

Discussion: https://postgr.es/m/CACpMh+DLrk=fDv07MNpBT4J413fDAm+gmMXgi8cjPONE+jvzuw@mail.gmail.com

Files

PathChange+/−
src/pl/plpython/plpy_exec.c modified +8 −4

Discussion