Fix overridden callbacks in pg_rewind.
Daniel Gustafsson <dgustafsson@postgresql.org>
Fix overridden callbacks in pg_rewind. The <source>_traverse_files functions take a callback for processing files, but both the local and libpq source implementations called the function directly without using the callback argument. While there is no bug right now as the function called is the same as the callback, fix by calling the callback to reduce the risk of subtle bugs in the future. Author: Junwang Zhao <zhjwpku@gmail.com> Reviewed-by: Richard Guo <guofenglinux@gmail.com> Discussion: https://postgr.es/m/CAEG8a3Jdwgh+PZr2zh1=t8apA4Yz8tKq+uubPqoCt14nvWKHEw@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/bin/pg_rewind/libpq_source.c | modified | +1 −1 |
| src/bin/pg_rewind/local_source.c | modified | +1 −1 |
Discussion
- [pg_rewind] use the passing callback instead of global function 3 messages · 2023-04-26