Preliminary code review for anonymous-composite-types patch: fix breakage
Tom Lane <tgl@sss.pgh.pa.us>
Preliminary code review for anonymous-composite-types patch: fix breakage of functions returning domain types, update documentation for typtype, move get_typtype to lsyscache.c (actually, resurrect the old version), add defense against creating pseudo-typed table columns, fix some bogus list-parsing in grammar. Issues remain with respect to alias handling and type checking; Joe is on those.
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/catalogs.sgml | modified | +5 −4 |
| src/backend/access/common/tupdesc.c | modified | +4 −6 |
| src/backend/catalog/heap.c | modified | +23 −13 |
| src/backend/catalog/pg_proc.c | modified | +3 −4 |
| src/backend/executor/functions.c | modified | +2 −2 |
| src/backend/executor/nodeFunctionscan.c | modified | +4 −5 |
| src/backend/parser/gram.y | modified | +30 −38 |
| src/backend/parser/parse_relation.c | modified | +7 −33 |
| src/backend/utils/cache/lsyscache.c | modified | +3 −5 |
| src/include/catalog/pg_type.h | modified | +7 −6 |
| src/include/parser/parse_relation.h | modified | +1 −2 |
| src/include/utils/lsyscache.h | modified | +2 −1 |