Do all accesses to shared buffer headers through volatile-qualified
Tom Lane <tgl@sss.pgh.pa.us>
Do all accesses to shared buffer headers through volatile-qualified pointers, to ensure that compilers won't rearrange accesses to occur while we're not holding the buffer header spinlock. It's probably not necessary to mark volatile in every single place in bufmgr.c, but better safe than sorry. Per trouble report from Kevin Grittner.
Files
| Path | Change | +/− |
|---|---|---|
| contrib/pg_buffercache/pg_buffercache_pages.c | modified | +7 −20 |
| src/backend/storage/buffer/bufmgr.c | modified | +45 −44 |
| src/backend/storage/buffer/freelist.c | modified | +4 −4 |
| src/include/storage/buf_internals.h | modified | +8 −3 |