In basebackup.c, refactor to create verify_page_checksum.
Robert Haas <rhaas@postgresql.org>
In basebackup.c, refactor to create verify_page_checksum. If checksum verification fails for a particular page, we reread the page and try one more time. The code that does this somewhat complex and difficult to follow. Move some of the logic into a new function and rearrange the code a bit to try to make it clearer. This way, we don't need the block_retry Boolean, a couple of other variables move from sendFile() into the new function, and some code is now less deeply indented. Patch by me, reviewed by David Steele. Discussion: http://postgr.es/m/CA+TgmoYt5jXH4U6cu1dm9Oe2FTn1aae6hBNhZzJJjyjbE_zYig@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/backup/basebackup.c | modified | +104 −84 |
Discussion
- trying again to get incremental backup 106 messages · 2023-06-14 → 2024-10-28