Fix grammar's AND/OR flattening to work with operator_precedence_warning.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 05104f693646c0a4ae446e79cb89057497da17e4
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2016-06-03T23:12:29Z
Releases: 9.6.0
Fix grammar's AND/OR flattening to work with operator_precedence_warning.

It'd be good for "(x AND y) AND z" to produce a three-child AND node
whether or not operator_precedence_warning is on, but that failed to
happen when it's on because makeAndExpr() didn't look through the added
AEXPR_PAREN node.  This has no effect on generated plans because prepqual.c
would flatten the AND nest anyway; but it does affect the number of parens
printed in ruleutils.c, for example.  I'd already fixed some similar
hazards in parse_expr.c in commit abb164655, but didn't think to search
gram.y for problems of this ilk.  Per gripe from Jean-Pierre Pelletier.

Report: <fa0535ec6d6428cfec40c7e8a6d11156@mail.gmail.com>

Files

PathChange+/−
src/backend/parser/gram.y modified +16 −4