Fix assignment to array of domain over composite.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 04dae19f4d5067b35b421dcd43175a5059747800
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-10-19T17:54:45Z
Releases: 14.1
Fix assignment to array of domain over composite.

An update such as "UPDATE ... SET fld[n].subfld = whatever"
failed if the array elements were domains rather than plain
composites.  That's because isAssignmentIndirectionExpr()
failed to cope with the CoerceToDomain node that would appear
in the expression tree in this case.  The result would typically
be a crash, and even if we accidentally didn't crash, we'd not
correctly preserve other fields of the same array element.

Per report from Onder Kalaci.  Back-patch to v11 where arrays of
domains came in.

Discussion: https://postgr.es/m/PH0PR21MB132823A46AA36F0685B7A29AD8BD9@PH0PR21MB1328.namprd21.prod.outlook.com

Files

Discussion